Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS renaming in version 1.15.1 breaks dependency compatibility #199

Closed
jimmyangel opened this issue Jul 8, 2021 · 2 comments · Fixed by #203
Closed

CSS renaming in version 1.15.1 breaks dependency compatibility #199

jimmyangel opened this issue Jul 8, 2021 · 2 comments · Fixed by #203

Comments

@jimmyangel
Copy link

maplibre-gl-js version: 1.15.1

browser: Any

Steps to Trigger Behavior

  1. Define maplibre dependency in package.json (e.g., "maplibre-gl": ">=1.14.0)
  2. Define additional dependency in package.json (e.g., "mapbox-gl-style-switcher": "^1.0.8")
  3. npm install will upgrade to maplibre version 1.15.1 which contains breaking changes, in this case, mapbox-gl-style-switcher expects names of css classes to begin with mapboxgl- but they have been renamed to maplibregl-

Expected Behavior

Non-breaking changes when going from 1.14 to 1.15

Actual Behavior

All library dependencies that rely on mapbox class names stop working. Temporary workaround is to pin the dependency to "maplibre-gl": "=1.14.0" which is not ideal.

Breaking changes should be introduced in major version increases, i.e.., 2.0.0 and above.

@astridx
Copy link
Contributor

astridx commented Jul 9, 2021

Thanks for reporting this.
It is related to #83.

HarelM pushed a commit that referenced this issue Jul 12, 2021
Addresses concerns voiced in #83, #185
Resolves #199

* fix breaking changes to css classnames

* bump version to 1.15.2
@jimmyangel
Copy link
Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants