Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay loading of tile stamps until after initializing the session #4044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Aug 29, 2024

The tilesets referenced by stored tile stamps may rely on custom types defined in the project and possibly even on custom tileset formats added by extensions. Hence, it is better to wait with loading them until after the project has been loaded and script manager is initialized.

The user will still run into issues when the project isn't loaded on startup, but this at least makes running into issues less likely.

It could help to force reloading of the stamps when switching projects.

The tilesets referenced by stored tile stamps may rely on custom
types defined in the project and possibly even on custom tileset formats
added by extensions. Hence, it is better to wait with loading them until
after the project has been loaded and script manager is initialized.

The user will still run into issues when the project isn't loaded on
startup, but this at least makes running into issues less likely. It could
help to force reloading of the stamps when switching projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant