Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error of exporting map file or tileset file #4015

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

snagasawa
Copy link
Contributor

@snagasawa snagasawa commented Jul 20, 2024

Hi, thank you to develop such a great tool ! :)

I tried to export map to tscn file by CLI and got failed, then a defailed message wasn't printed.
I added logging error message, now it can do that.

./Tiled --export-map main.tmx main.tscn --embed-tilesets

Failed to export map to target file.
Could not find .godot project in file path for file /Users/username/src/github.com/snagasawa/tiled-export-to-godot-sample/images/sample.png

environment:

  • OS: MacOS v14.3 sonoma
  • tiled: v1.11.0

@bjorn
Copy link
Member

bjorn commented Jul 20, 2024

Hey @snagasawa, the change looks good, thanks!

Can you apply the same change to the tileset export blow? The code is unfortunately a bit duplicated.

@snagasawa snagasawa force-pushed the log-error-of-exporting-map-file branch from 4e3a779 to 2f36807 Compare July 21, 2024 00:08
@snagasawa
Copy link
Contributor Author

Hi @bjorn, thank you to review. :)
Sure! I have done and rebased commits.

@snagasawa snagasawa changed the title Log error of exporting map file Log error of exporting map file or tileset file Jul 21, 2024
@bjorn bjorn force-pushed the log-error-of-exporting-map-file branch from 2f36807 to 1f7452c Compare September 10, 2024 17:53
@bjorn bjorn merged commit 694705b into mapeditor:master Sep 10, 2024
12 of 13 checks passed
@bjorn
Copy link
Member

bjorn commented Sep 10, 2024

Thanks, and sorry for the delay in merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants