Qbs: Use pkg-config to depend on zlib #3999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we should support building Tiled with zlib in some strange location, like on NixOS. To support this on the latest version of Qbs, we need to set Project.qbsModuleProviders since it no longer falls back on pkg-config by default. Since this property was introduced in Qbs 1.21, this becomes the minimum Qbs version.
|
Since Ubuntu 22.04 apparently ships with Qbs 1.19.2, we'll need wait with this until we no longer support this OS or find a workaround. Also, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we should support building Tiled with zlib in some strange location, like on NixOS.
To support this on the latest version of Qbs, we need to set
Project.qbsModuleProviderssince it no longer falls back onpkg-configby default. Since this property was introduced in Qbs 1.21, this becomes the minimum Qbs version.