-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset to all settings to default except plugins. #3828
base: master
Are you sure you want to change the base?
Conversation
However, I don't know how to translate the button "Reset to default" to other languages. |
Thanks for implementing this! Consider calling it "reset to default" instead of "restore to default" like it is now. When looking for such an option, that's usually the keyword I'm looking for, whereas "restore" is for when I'm looking for data that has been deleted rather than changed. You yourself even called it "reset to default" in your comment. As for translations, I think display strings in the .ui file automatically get passed through the translation system and no special mark-up is needed. As far as I can tell form other PRs, you also don't need to add it to any list of strings or anything, that seems to be handled automatically. So, as far as I can tell, you're all set! The actual translations are provided by other contributors and are usually only done after each new Tiled version's string freeze. |
Thank you very much for your comment and for clarifications. I agree with you, and that it is better to rename the buttons to "Reset" instead of "Restore". Also, it is very nice that the languages can be translated automatically. |
I agree there should be a way to reset all the settings, but I'm not sure if we need it to work per-page, because:
I personally think what #3713 was about is to provide an action that basically resets Tiled to the state of first launch. I would suggest to just clear everything using |
@0xchatware I forgot to ask, would you be interested to adjust your PR to work as I described above? Also, I'm sorry for not giving feedback earlier. |
Implements #3713.