Fix selection highlight issue for unordered layer lists set by script

[lhiginbotham]

• fixes Scripting: Assigned map.selectedLayers displays incorrectly #3451 where layer selection highlighting was bugging out if the newly set selection was not ordered by layer ID
• this seems to be an event interplay issue with the following sequence:
  • script sets the layer selection to some array
  • first step in handling that is to set the currently selected layers to be the full array, triggering LayerView::selectedLayersChanged to select the whole range
  • second step is to make sure that the mCurrentLayer variable is pointing to an object within that array selection, which in this bad case it is not, so we end up calling setSelectedLayers with one item, triggering LayerView::selectedLayersChanged again with a single item and effectively clearing out the selection we had just highlighted
• fix this by doing the second step before the first step

[lhiginbotham]

FYI @bjorn @eishiya let me know what you think about this change (you will be a better judge of this fix than I am, a newcomer 😄)

[bjorn]

let me know what you think about this change

There was probably a reason for having those function in that order, such that reversing it has a high chance of introducing another issue elsewhere. We'll have to be careful with this one.

Unfortunately I won't have time anymore in October to investigate this, but for your Hacktoberfest contributions we can still get #3513 merged. :-)