ignore features with null geometry #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This should pass once #49 is merged and this is rebased against that. |
mourner
requested changes
Jun 19, 2017
andrewharvey
force-pushed
the
null-geometry
branch
from
94711cd to
6fc9f98
Compare
|
@mourner updated, is that what you meant? |
mourner
requested changes
Jun 19, 2017
index.js
Outdated
| @@ -265,6 +271,10 @@ function createCluster(x, y, id, numPoints, properties) { | |||
| } | |||
|
|
|||
| function createPointCluster(p, id) { | |||
| if (!p.geometry) { | |||
| return null; | |||
| } | |||
There was a problem hiding this comment.
You could move this part inside the loop above.
index.js
Outdated
| @@ -43,7 +43,13 @@ SuperCluster.prototype = { | |||
| this.points = points; | |||
|
|
|||
| // generate a cluster object for each point and index input points into a KD-tree | |||
| var clusters = points.map(createPointCluster); | |||
| var clusters = []; | |||
| points.forEach(function (point, i) { | |||
There was a problem hiding this comment.
Avoid using forEach in performance-critical code. for (var i = 0; i < points.length; i++) is much faster.
|
@mourner how's this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid for GeoJSON features to have a null geometry, this PR aims to ignores such features rather than crashing.