refactor code #37
Merged
refactor code #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Feb 8, 2017
index.js
Outdated
| if (this.options.reduce) { | ||
| this._accumulate(clusterProperties, b); | ||
| } | ||
| // filter out neighbors that already processed |
index.js
Outdated
| this.trees[z + 1] = kdbush(clusters, getX, getY, this.options.nodeSize, Float32Array); | ||
|
|
||
| clusters = this._cluster(clusters, z); // create a new set of clusters for the zoom | ||
| // create a new set of clusters for the zoom and index input points into a KD-tree |
There was a problem hiding this comment.
Since we index new clusters and not input points at this stage, we could say:
create a new set of clusters for the zoom and index them with a KD-tree
|
OK, updated the mentioned comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I repeated the code that share same logic, maybe better for readability.