Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant map calls on reduce #131

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Avoid redundant map calls on reduce #131

merged 1 commit into from
Jul 23, 2019

Conversation

mourner
Copy link
Member

@mourner mourner commented Jul 23, 2019

Closes #130. With this change, when reduce is set, map will only be called once per original point, rather per unclustered point per zoom. This improves performance of map/reduce slightly, but not significantly since map isn't a bottleneck in JS (although it might be with more complex map functions). cc @zmiao

@mourner mourner merged commit 8e60498 into master Jul 23, 2019
@mourner mourner deleted the less-map branch July 23, 2019 09:44
@mourner mourner mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questions about map and reduce options
1 participant
@mourner