Fix broken tests #96
Merged
Fix broken tests #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the transitive dependencies (protocol-buffers-schema) got
upgraded, causing some of the compile tests to break, most notably
with this message:
Fields of type MessageType cannot be declared [packed=true]. Only
repeated fields of primitive numeric types (types which use the
varint, 32-bit, or 64-bit wire types) can be declared "packed". See
https://developers.google.com/protocol-buffers/docs/encoding#optional
Remove the MessageType enum and use int32 in its place.
The new version of protocol-buffers-schema also changed how enums are
represented in json, breaking another test.
mourner
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the transitive dependencies (protocol-buffers-schema) got
upgraded, causing some of the compile tests to break, most notably
with this message:
Remove the
MessageTypeenum and useint32in its place.The new version of
protocol-buffers-schemaalso changed how enums arerepresented in json, breaking another test.