-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade npmlog + upgrade gauge to address #623 #624
Conversation
- Still keeps at least ansi-regex@5.0.1 thanks to gauge@3.0.2 release - And therefore can maintain node v10 support
I can answer this and save you some time: because this was a pre-emptive drop in support. Nothing in the code was changed that would have broke in node10. The only thing that would catch something like this would be the |
Ah! Thank you for explaining that. I saw the |
Hmm, @wraithgar - I just tried, locally, running
against the
Any idea why that is not erroring? I would assume I'd get a non-zero return code from |
Perhaps I need to add |
It looks like |
🎉 thanks for taking on this work. I know I'm like the only person who runs tests with Edit: my experience has been, this is good to treat as a breaking change, or you eventually get burned by someone upstream using a new feature, e.g., ESM in the case of having a dep move to Node 12. |
@bcoe - no problem, I'd like to be like you. I'm still struggling however to replicate any kind of error or failure with node v10 (or 8 for that matter) and the |
@springmeyer this is the approach I've been taking that catches things: https://github.com/googleapis/nodejs-logging/blob/main/.github/workflows/ci.yaml#L22 |
@springmeyer I did some local testing too, and a couple things I noticed:
Once I did both these things, I'm getting the following with a local check out of node-pre-gyp$ npm i -production --engine-strict
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for npmlog@6.0.0: wanted: {"node":"^12.13.0 || ^14.15.0 || >=16"} (current: {"node":"10.24.1","npm":"6.14.15"})
npm ERR! notsup Not compatible with your version of node/npm: npmlog@6.0.0
npm ERR! notsup Not compatible with your version of node/npm: npmlog@6.0.0
npm ERR! notsup Required: {"node":"^12.13.0 || ^14.15.0 || >=16"}
npm ERR! notsup Actual: {"npm":"6.14.15","node":"10.24.1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this work 😄
Got it, thank you @bcoe - npm@7 + using node v10 allowed me to replicate (and it caught another incompatible dependency - action-walk). |
This is now published as |
Thanks for this work 👏 it allows us to avoid dropping Node 10 on |
Downgrade npmlog + upgrade gauge to address mapbox#623
This should address #623
TODO: