Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields_to_exclude to start_tile_feature() #78

Closed
wants to merge 1 commit into from
Closed

Conversation

ljbade
Copy link

@ljbade ljbade commented Feb 5, 2015

Closes #77

@springmeyer Is this what you had in mind?

Needs a test case.

@springmeyer
Copy link
Contributor

looks good for testing your optimization. we should also consider the alternative design of accepting a list of fields to include. I'd need to mull on this more to have a strong opinion.

while I'm brainstorming: The other thing we should add is filtering support such that you could pass down a 'mapnik::expression' string to be evaluated and throw out features not matching. the goal of this would be to allow rudimentary filtering support for datasource other than Postgres.

@ljbade
Copy link
Author

ljbade commented Feb 8, 2015

@springmeyer I will have to read up on Mapnik expressions.

@ljbade
Copy link
Author

ljbade commented Feb 8, 2015

@springmeyer not sure why the build is failing with the missing std::end std::begin on Travis. Compiles fine on my machine.

@springmeyer
Copy link
Contributor

This pull has merit, but before being ready would need 1) unit tests, 2) gut check to make sure performance is not impacted (and if it is, some quicker method to skip the std::find if not needed).

@flippmoke
Copy link
Member

Closing this pull request because it is so far behind master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to drop certain columns
3 participants