Move arrow when maneuver is swiped #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
commented
Aug 24, 2017
| @@ -541,6 +541,10 @@ extension RouteMapViewController: RoutePageViewControllerDelegate { | |||
| mapView.setUserTrackingMode(.followWithCourse, animated: true) | |||
| } | |||
| } | |||
|
|
|||
| if let stepIndex = routeController.routeProgress.currentLeg.steps.index(where: { $0 == step }) { | |||
| mapView.addArrow(route: routeController.routeProgress.route, legIndex: routeController.routeProgress.legIndex, stepIndex: stepIndex) | |||
There was a problem hiding this comment.
We'll have to figure out how to handle multiple legs here. I'm not sure even what happens when you try to swipe past the current leg.
There was a problem hiding this comment.
Could we get away with disallowing swiping to later legs for now?
There was a problem hiding this comment.
Yep, that's how this will work right now. You will only be able to swipe on the current leg.
1ec5
reviewed
Aug 24, 2017
MapboxNavigation/MGLMapView.swift
Outdated
| let maneuverCoordinate = routeProgress.currentLegProgress.upComingStep?.maneuverLocation | ||
| let polylineCoordinates = routeProgress.route.coordinates | ||
| func addArrow(route: Route, legIndex: Int, stepIndex: Int) { | ||
| let step = route.legs[legIndex].steps[stepIndex] |
There was a problem hiding this comment.
If the user manages to swipe past the last step in the leg or the last step in the route, this line will crash.
There was a problem hiding this comment.
Which you cannot do, but valid point, will guard.
ericrwolfe
approved these changes
Aug 24, 2017
|
Merging after I merge #270 |
added 2 commits
August 24, 2017 11:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #523
/cc @1ec5 @frederoni