Allow custom (destination) annotations #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2017 10:29
bsudekum
commented
Jun 8, 2017
|
|
||
| If this method is unimplemented, the navigation map view will represent the destination annotation with the default marker. | ||
| */ | ||
| @objc optional func navigationMapView(_ mapView: MGLMapView, imageFor annotation: MGLAnnotation) -> MGLAnnotationImage? |
There was a problem hiding this comment.
Should this instead be:
@objc optional func navigationMapView(_ mapView: NavigationMapView, imageFor annotation: MGLAnnotation) -> MGLAnnotationImage?
There was a problem hiding this comment.
Let's stick with MGLMapView for now. Makes it easier to find the right documentation.
|
Image annotations is a good start but we should also expose |
frederoni
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition allows the developer to provide a custom annotation image for all annotations on the map. Note, the only annotations on the map currently is the destination marker.
/cc @frederoni