Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug with multileg routes #1979

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix a bug with multileg routes #1979

merged 2 commits into from
Feb 21, 2019

Conversation

frederoni
Copy link
Contributor

Fixes a regression introduced in #1904

  • Advance leg index when NavigationServiceDelegate.navigationService(_:didArriveAt:) returns true.

cc @JThramer

@frederoni frederoni requested review from JThramer and 1ec5 February 18, 2019 13:15
@frederoni frederoni self-assigned this Feb 18, 2019
@frederoni frederoni added bug Something isn’t working ✓ ready for review labels Feb 18, 2019
JThramer
JThramer approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice catch!

@frederoni frederoni merged commit dc27dca into master Feb 21, 2019
@1ec5
Copy link
Contributor

1ec5 commented Feb 23, 2019

Added a blurb to the changelog in 90d37ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@frederoni frederoni

Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frederoni @1ec5 @JThramer @akitchen