-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pitch
and distance-from-center
expressions support
#1662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example looks 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side q - do we need an example for distance-from-center
as well?
9822d81
to
f94417a
Compare
And also updated the screen recording in the PR description. |
e21dee4
to
586b8c2
Compare
586b8c2
to
132a2fa
Compare
Summary of changes
Added support for
pitch
anddistanceFromCenter
in filter expressions for symbol layers.See counterpart
gl-js
mapbox/mapbox-gl-js#10795User impact (optional)
Users can now use
pitch {...}
anddistanceFromCenter {..}
expressions in symbol layers.See following capture where
mag x
text symbols are hidden when the pitch is higher than 70º.pitch_distance_layer_filter.mp4
Pull request checklist:
@JvmOverloads
,@file:JvmName
, etc).make update-api
to update generated api files, if there's public API changes, otherwise theverify-api-*
CI steps might fail.check changelog
CI step will fail.v10.[version]
release branch fix / enhancement, merge it tomain
firstly and then port tov10.[version]
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.