This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Label legibility improvements: pitch-scaling and pitched line-following (bitrise workaround) #9467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on tile distance from camera.
Necessary because collision boxes now change shape based on while tile they're part of.
…els. Viewport-aligned curved labels start to look very strange in the distance. Until we have a better system for projecting them, just prevent them from showing.
…ore closely with symbol shaders.
This prevents TilePyramid from sharing wrapped copies of tiles. This is necessary because two wrapped tiles no longer share the same CollisionTile.
… while waiting for new ones.
It used to overwrite values in the middle of the calculation which would cause problems when `out` and `a` were a reference to the same vector.
port mapbox/mapbox-gl-js#4781 This improves legibility of labels that follow lines in pitched views. The previous approach used the limited information in the shader to calculate put the glyph in approximatelyright place. The new approach does this more accurately by doing it on the cpu where we have access to the entire line geometry.
and rename BufferUsageType to BufferUsage
ansis
force-pushed
the
cloer_text_pitch_scaling_2
branch
from
6017893 to
7e7aaa1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new pr for #9009 to work around bitrise reporting failures.
@ChrisLoer