Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Fix typo #6140

Merged
merged 1 commit into from
Aug 24, 2016
Merged

[ios] Fix typo #6140

merged 1 commit into from
Aug 24, 2016

Conversation

tmpsantos
Copy link
Contributor

s/Reponse/Response

@mention-bot
Copy link

@tmpsantos, thanks for your PR! By analyzing this pull request, we identified @incanus and @1ec5 to be potential reviewers.

s/Reponse/Response
@tmpsantos
Copy link
Contributor Author

/cc @frederoni

@frederoni
Copy link
Contributor

frederoni commented Aug 24, 2016

Should be done in the dependency but this is correct since it's copied/checked in.
(https://github.com/AliSoftware/OHHTTPStubs)

👍

@tmpsantos
Copy link
Contributor Author

Should be done in the dependency but this is correct since it's copied/checked in.
(https://github.com/AliSoftware/OHHTTPStubs)

Thanks for pointing out. I will make a PR there too.

@tmpsantos tmpsantos merged commit 7a84a0e into master Aug 24, 2016
@tmpsantos tmpsantos deleted the tmpsantos-ios_typo branch August 24, 2016 15:24
@tmpsantos
Copy link
Contributor Author

tmpsantos commented Aug 24, 2016

@friedbunny
Copy link
Contributor

Do you recall why OHHTTPStubs isn’t a git submodule, @1ec5? Submodules can be a headache, but we’re probably always going to be reliant on them in this project.

@1ec5
Copy link
Contributor

1ec5 commented Aug 24, 2016

I don't think there's a good reason it's checked in. We could certainly turn it into a submodule.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants