This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Do not allow multipoint annotations to be assigned views #5770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue
In v3.3.x, it was possible for any annotation class to be assigned an annotation view. If your implementation of
-mapView:viewForAnnotation:
didn't check ifannotation
was a kind ofMGLPointAnnotation
, you could end up drawing view annotations forMGLMultiPoint
subclasses, such asMGLPolygon
:As this fix uses the
MGLMultiPoint
superclass to exclude polygons and polylines, we will have to reevaluate if/when the proposed geometry class hierarchy changes in #5201 happen./cc @boundsj @1ec5 @incanus @frederoni