Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Compass, user dot, annotations are inaccessible on iOS #1493

Closed
1ec5 opened this issue May 10, 2015 · 3 comments · Fixed by #1496
Closed

Compass, user dot, annotations are inaccessible on iOS #1493

1ec5 opened this issue May 10, 2015 · 3 comments · Fixed by #1496
Assignees
Labels
bug iOS Mapbox Maps SDK for iOS

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 10, 2015

With VoiceOver enabled, the attribution button and annotation callouts can receive focus, but the compass, user dot, and annotation pins cannot. The pins are rendered directly in GL, but there should still be a way to give them accessibility regions. The other views all have accessibility labels.

@incanus
Copy link
Contributor

incanus commented May 11, 2015

there should still be a way to give them accessibility regions

Oof, that might be tricky, depending on how we do it. Realtime means we'd have to mirror annotations to the view hierachy, which is going to be high overhead. Doing so after a small delay might be a decent approach.

@1ec5
Copy link
Contributor Author

1ec5 commented May 11, 2015

I’m looking at creating UIAccessibilityElements on the fly as UIAccessibility asks for them. These elements don’t have to be part of the view hierarchy, so there’s a lot less overhead.

@incanus
Copy link
Contributor

incanus commented May 11, 2015 via email

1ec5 added a commit that referenced this issue May 11, 2015
Lazily create and cache accessibility elements for annotations as UIAccessibility asks about them.

Fixes #1493.
@incanus incanus added this to the iOS Beta 2 milestone May 11, 2015
1ec5 added a commit that referenced this issue May 12, 2015
Lazily create and cache accessibility elements for annotations as UIAccessibility asks about them.

Fixes #1493.
@1ec5 1ec5 modified the milestones: iOS Beta 3, iOS Beta 2 Jun 15, 2015
@jfirebaugh jfirebaugh removed this from the iOS Beta 3 milestone Jun 29, 2015
@1ec5 1ec5 self-assigned this Oct 16, 2015
@incanus incanus added the P2 label Nov 4, 2015
1ec5 added a commit that referenced this issue Apr 17, 2016
Lazily create and cache accessibility elements for annotations as UIAccessibility asks about them.

Fixes #1493.
1ec5 added a commit that referenced this issue Apr 18, 2016
Lazily create and cache accessibility elements for annotations as UIAccessibility asks about them.

Fixes #1493.
1ec5 added a commit that referenced this issue Apr 21, 2016
Lazily create and cache accessibility elements for annotations as UIAccessibility asks about them.

Fixes #1493.
1ec5 added a commit that referenced this issue Apr 25, 2016
Lazily create and cache accessibility elements for visible annotations as UIAccessibility asks about them.

Sort the annotations’ accessibility elements by the annotations’ distance from the logical center (the center after accounting for padding, or the user dot when user tracking mode is on).

Updated the changelog.

Fixes #1493.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants