Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset more state after render frame #8132

Merged
merged 1 commit into from
Jun 5, 2019
Merged

reset more state after render frame #8132

merged 1 commit into from
Jun 5, 2019

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Apr 8, 2019 •
edited
Loading

fix #7801 by resetting more gl state to default values when the frame ends.

cc @Pessimistress

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • post benchmark scores
  • manually test the debug page

@ansis ansis requested a review from ryanhamley April 8, 2019 19:27
@ansis ansis mentioned this pull request Apr 8, 2019
Closed
@jamiebordewyk
Copy link

@ansis Do we have the last review needed to move this forward?

@ansis ansis requested a review from mourner April 25, 2019 21:18
mourner
mourner approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, pending benchmark results and maybe some manual perf testing — could this affect rendering performance overall?

@ansis
Copy link
Contributor Author

ansis commented Jun 5, 2019

Paint benchmarks are unaffected. The performance costs of these once-per-frame state change should be miniscule

@ansis ansis merged commit 981827c into master Jun 5, 2019
@mourner mourner deleted the reset-gl-state branch June 6, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@ryanhamley ryanhamley Awaiting requested review from ryanhamley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpredictable state when using custom layers
3 participants
@ansis @jamiebordewyk @mourner