Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update SDK compatibility versions for line-gradient #7281

Merged
merged 1 commit into from
Sep 20, 2018
Merged

[docs] Update SDK compatibility versions for line-gradient #7281

merged 1 commit into from
Sep 20, 2018

Conversation

captainbarbosa
Copy link
Contributor

Updates the SDK compatibility table for the new line-gradient property introduced in mapbox/mapbox-gl-native#12575.

@captainbarbosa captainbarbosa self-assigned this Sep 14, 2018
@captainbarbosa
Copy link
Contributor Author

captainbarbosa commented Sep 14, 2018 •
edited
Loading

@1ec5 I think I may have editing the wrong file (src/style-spec/reference/v8.json vs. your edits on docs/pages/style-spec.js in #7282). Can you confirm that I should be editing style-spec.js instead?

1ec5
1ec5 approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8.json is where you edit layer properties. #7282 touches a different file where source properties are defined in more of an ad-hoc fashion.

@captainbarbosa captainbarbosa merged commit a5f9d92 into mb-pages Sep 20, 2018
@captainbarbosa captainbarbosa deleted the ios-v4.0.0-update branch September 20, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees

@captainbarbosa captainbarbosa

Labels
docs 📜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbarbosa @1ec5