Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5827 unblock labels with overscaled tiles correctly #5859

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Dec 13, 2017

This fixes #5827 by using overscaledZ instead of canonical.z, letting overscaled tiles unblock labels correctly.

Launch Checklist

  • briefly describe the changes in this PR
  • [N/A] write tests for all new functionality
  • [N/A] document any changes to public APIs
  • [N/A] post benchmark scores
  • manually test the debug page

@jfirebaugh

@ansis ansis requested a review from jfirebaugh December 13, 2017 23:21
@jfirebaugh
Copy link
Contributor

Is it feasible to write a render regression test for this?

@ansis
Copy link
Contributor Author

ansis commented Dec 13, 2017

I think it should be feasible to add a regression test but I'm not sure it's worth it in this case. The changes I'm porting back from -native change the relevant part of CrossTileSymbolIndex entirely and pretty much eliminate this possibility of regressing this.

@ansis ansis merged commit 369baa3 into master Dec 14, 2017
@ansis ansis deleted the fix-5827 branch December 14, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels disappear when zooming out from overzoomed tile
2 participants