Refactor: remove SymbolInstancesArray, SymbolQuadsArray #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jfirebaugh
reviewed
Feb 6, 2017
| @@ -69,6 +69,7 @@ | |||
| "remark-html": "^5.0.1", | |||
| "request": "^2.79.0", | |||
| "sinon": "^1.15.4", | |||
| "st": "^1.2.0", | |||
There was a problem hiding this comment.
It's here. Is that dependency not working for you?
There was a problem hiding this comment.
Ah. Yeah, it wasn't working for me -- e.g. the start-debug script in the root package.json failed to find st.
There was a problem hiding this comment.
Oh right, start-server uses the st CLI. 👍
|
@lucaswoj @jfirebaugh @mollymerp This is mostly done, as discussed here: #4186 (comment). There's one render test mysteriously failing (because a road turned 180 degrees from waht's expected). Chasing that down now, but I think this is probably okay to 👀 nonetheless. |
|
This is awesome! |
anandthakker
force-pushed
the
refactor-symbol-instances
branch
from
3ae4de3 to
5fbb68b
Compare
These StructArrays were introduced with an eye towards the 'cross-source symbol placement' project, as a way to transfer all the information needed to re-place and then render symbols from the thread where each vector tile is parsed parsing occurs to the main thread for placement and rendering. However, data-driven styling presents a problem for this approach: for DDS, populating the paint attribute arrays requires both the feature property information (from the VT-parse thread) and the symbol layout information (because it dictates which features' paint attributes should be included). So, we aren't using SymbolInstancesArray (and SymbolQuadsArray) now, and will need a different approach when we revisit cross-source placement.
anandthakker
force-pushed
the
refactor-symbol-instances
branch
from
5fbb68b to
26ce1f3
Compare
|
@lucaswoj rebased onto master - this should be good to go 🤞 |
4 tasks
jfirebaugh
approved these changes
Feb 7, 2017
mapsam
pushed a commit
that referenced
this pull request
Feb 8, 2017
* Refactor: remove SymbolInstancesArray, SymbolQuadsArray These StructArrays were introduced with an eye towards the 'cross-source symbol placement' project, as a way to transfer all the information needed to re-place and then render symbols from the thread where each vector tile is parsed parsing occurs to the main thread for placement and rendering. However, data-driven styling presents a problem for this approach: for DDS, populating the paint attribute arrays requires both the feature property information (from the VT-parse thread) and the symbol layout information (because it dictates which features' paint attributes should be included). So, we aren't using SymbolInstancesArray (and SymbolQuadsArray) now, and will need a different approach when we revisit cross-source placement. * Add missing st dependency * Remove unused quadCount member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't using SymbolInstancesArray (and SymbolQuadsArray) now, and will need a different approach when we revisit cross-source placement, so this PR removes them, in favor of storing the necessary state down on each
SymbolBucketinstance (rather than at theWorkerTilelevel).