Pin webworkify to 1.2.0 #2700
Merged
Pin webworkify to 1.2.0 #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending a fix for browserify/webworkify#26 fixes #2677
|
cc @anandthakker, this might have implications for your work |
|
Thanks @lucaswoj. Also, my apologies: as a committer on webworkify and a participant on that particular thread, I could have prevented this. |
|
No worries @anandthakker 😄 |
blanchg
pushed a commit
to blanchg/mapbox-gl-js
that referenced
this pull request
Jun 13, 2016
Pending a fix for browserify/webworkify#26 fixes mapbox#2677
|
@lucaswoj Update -- just pushed (what I believe should be) a fix for this and published as webworkify@1.3.0. Have not actually confirmed it on IE. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upstream bug in
webworkerifybrowserify/webworkify#26 is causing GL JS to not work in IE. This PR pins the dependency pending an upstream fix.fixes #2677