Convert mapbox plugin #13390
Open
Convert mapbox plugin #13390
+58
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit types for variables, parameters, and return values in TypeScript files. * **src/data/dem_data.ts** - Add explicit types for variables, parameters, and return values. - Include interfaces for Mapbox-specific objects or data structures. - Modify constructor and methods to use explicit types. * **src/data/evaluation_feature.ts** - Update the type of `id` property in `EvaluationFeature` to `number | string | undefined`. * **src/data/feature_index.ts** - Add explicit return type `void` for `insert` method. - Add explicit types for variables in `query` method.
|
|
|
Hey, @jknohr thank you for your contribution! Could you explain the reasoning behind these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.