Disable cooperative gestures in fullscreen for touch panning and add screen reader alert for cooperative gestures warning message #12058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnailBones
force-pushed
the
aidan/touch-pan-fullscreen
branch
from
619da78 to
4fdd739
Compare
SnailBones
force-pushed
the
aidan/touch-pan-fullscreen
branch
from
4fdd739 to
bb2003b
Compare
SnailBones
changed the title
SnailBones
changed the title
karimnaaji
approved these changes
Jul 6, 2022
src/ui/handler/scroll_zoom.js
Outdated
| @@ -112,7 +112,7 @@ class ScrollZoomHandler { | |||
| * const isScrollZoomEnabled = map.scrollZoom.isEnabled(); | |||
| */ | |||
| isEnabled(): boolean { | |||
| return !!this._enabled; | |||
| return this._enabled; | |||
There was a problem hiding this comment.
Why do we need this diff, as this._active, this._zooming and this._enabled may not be initialized?
There was a problem hiding this comment.
Good point Karim! It seemed a bit strange to be applying !! to a value that's already a boolean, but I now realize that this is potentially a breaking change. Thoughts on setting these values to false in the constructor?
There was a problem hiding this comment.
false in the constructor works, but also not against leaving as is!
There was a problem hiding this comment.
Readded the !!s, I've also added them to TouchPanHandler for consistency.
karimnaaji
approved these changes
Jul 6, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11635
Fixes https://github.com/mapbox/gl-js-team/issues/458
Before:
voiceover-main.mov
After:
voiceover-fix.mov
Launch Checklist
mapbox-gl-jschangelog:<changelog>FixcooperativeGesturespreventing panning on mobile while in fullscreen. Add screen reader alert for cooperative gestures warning message.</changelog>