Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max sprite size to 1024 #2761

Closed
danswick opened this issue Jun 17, 2016 · 4 comments · Fixed by #2802
Closed

Increase max sprite size to 1024 #2761

danswick opened this issue Jun 17, 2016 · 4 comments · Fixed by #2802

Comments

@danswick
Copy link
Contributor

Mapbox GL Native supports sprites up to 1024 x 1024. Mapbox GL JS should match to ensure sprites created for mobile don't break on the web.

cc @1ec5

@lucaswoj
Copy link
Contributor

My understanding, per #141, is that GL JS could support a sprite atlas of 1024px square. I can't seem to find a reason why we are using a 512px square sprite atlas instead.

Thoughts @bhousel @jfirebaugh @kkaefer?

@kkaefer
Copy link
Member

kkaefer commented Jun 20, 2016

We can use 1024x1024 atlases, but we should also implement #141 (comment)

@spavett
Copy link

spavett commented Jun 20, 2016

Question maybe related to this: I'm trying to add some SVG icons to a layer in the streets base map in Studio. These icons are pretty large and meant to overlap - one is 400 x 400 (as an SVG). The next one is 120 x 120. This additional icon doesn't seem to work in conjunction with the first. I can get them to work individually but not together. You can see the size of the icons on the example screen grab. Is this to do with this glyph size? I see a "SpriteAtlas out of space" warning in my js console in the browser.

streets___mapbox

@lucaswoj
Copy link
Contributor

lucaswoj commented Jun 27, 2016

@spavett Yes, it sounds like your sprites are too large for GL JS as it is currently implemented.

In the future, we would prefer if you used GitHub only for feature requests and bug reports, directing all other questions to StackOverflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants