Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception thrown by "drag rotate" handler #2680

Closed
lucaswoj opened this issue Jun 6, 2016 · 2 comments · Fixed by #2689 or #2840
Closed

Fix exception thrown by "drag rotate" handler #2680

lucaswoj opened this issue Jun 6, 2016 · 2 comments · Fixed by #2689 or #2840
Labels
bug 🐞 release blocker ⛔

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Jun 6, 2016

per 4dd6786#commitcomment-17747349
@lucaswoj lucaswoj changed the title Fix DragRotate handler Fix exception thrown by "drag rotate" handler Jun 6, 2016
@lucaswoj lucaswoj mentioned this issue Jun 6, 2016
Closed
blanchg added a commit to blanchg/mapbox-gl-js that referenced this issue Jun 7, 2016
@blanchg
Fix for issue mapbox#2680, root cause map.options is no longer available
bcee79f
@blanchg blanchg mentioned this issue Jun 7, 2016
Merged
lucaswoj pushed a commit that referenced this issue Jun 8, 2016
@blanchg @lucaswoj
Fix for issue #2680, root cause map.options is no longer available (#…
c82562c 
…2689)

* Fix for issue #2680, root cause map.options is no longer available

* Apply PR comments
blanchg added a commit to blanchg/mapbox-gl-js that referenced this issue Jun 13, 2016
@blanchg
Fix for issue mapbox#2680, root cause map.options is no longer availa…
dbab045 
…ble (mapbox#2689)

* Fix for issue mapbox#2680, root cause map.options is no longer available

* Apply PR comments
@scothis
Copy link
Contributor

scothis commented Jun 15, 2016

Still seeing this error with 0.20.0

TypeError: undefined is not an object (evaluating 'this.options.bearingSnap')
  at snapToNorth(node_modules/mapbox-gl/js/ui/camera.js:241:55)
  at this(node_modules/mapbox-gl/js/ui/handler/touch_zoom_rotate.js:170:16)

@scothis scothis reopened this Jun 15, 2016
@lucaswoj
Copy link
Contributor Author

problematic line of code: https://github.com/mapbox/mapbox-gl-js/blob/master/js/ui/camera.js#L241

lucaswoj pushed a commit that referenced this issue Jul 7, 2016
Fix exception thrown by DragRotateHandler
d24d477 
fixes #2680
@lucaswoj lucaswoj mentioned this issue Jul 7, 2016
Merged
mourner pushed a commit that referenced this issue Jul 8, 2016
@lucaswoj @mourner
Fix exception thrown by DragRotateHandler (#2840)
0399e19 
fixes #2680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 release blocker ⛔
Projects
None yet
Milestone
No milestone
2 participants
@lucaswoj @scothis