Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow features to have numeric ids #769

Merged
merged 2 commits into from
May 10, 2018
Merged

allow features to have numeric ids #769

merged 2 commits into from
May 10, 2018

Conversation

mcwhittemore
Copy link
Contributor

@mcwhittemore mcwhittemore commented Apr 27, 2018

Closes #738
Closes #777

@mmoutenot do you take a look at this and confirm I've fixed the bug?

@mrshll
Copy link

mrshll commented May 8, 2018

Sorry for the delay. I reviewed the MR and it looks good 👍

I have not had an opportunity yet to install this branch on my codebase, however.

@jackwkinsey
Copy link

I've confirmed that this fix should also address my issue as well!

Thanks!

@mcwhittemore mcwhittemore merged commit 5c85909 into master May 10, 2018
@mcwhittemore mcwhittemore deleted the fix-738 branch May 10, 2018 14:02
@mcwhittemore
Copy link
Contributor Author

@jackwkinsey & @mmoutenot - I've shipped 1.0.9 to npm.

@mollymerp - do version of gl-draw appear in the Mapbox CDN automagicly, or is there a next step I need to take to do that?

@mollymerp
Copy link
Contributor

@mcwhittemore yes they get uploaded automatically by travis, but the version doesn't get bumped on the gl-js examples page. I've tagged you in a PR updating the example page!

@friendlyswiss
Copy link

friendlyswiss commented May 20, 2018

@mcwhittemore thanks for this fix!

It looks like a few methods still only take feature IDs as strings:

-get
-changeMode
-setFeatureProperty

Specifically, I'm running into problems using draw.changeMode('direct_select', 'some_numeric_id').

I'm a non-dev working on a side project, so I'm grateful for any help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants