Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors on OSX #77

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Fix compilation errors on OSX #77

merged 1 commit into from
Jul 26, 2018

Conversation

nagineni
Copy link
Contributor

This fixes compilation errors on OSX when -Werror,-Wshorten-64-to-32 flags are passed to the compiler.

Errors:

mapbox-gl-native/mason_packages/headers/geojsonvt/6.5.0/include/mapbox/geojsonvt/simplify.hpp:40:40: error: implicit conversion loses integer precision: 'unsigned long' to 'const int32_t' (aka 'const int') [-Werror,-Wshorten-64-to-32]
    const int32_t mid = (last - first) >> 1;

@nagineni
Fix compilation errors on OSX
04d9b5e 
This fixes compilation errors on OSX when -Werror,
-Wshorten-64-to-32 flags are passed to the compiler.
@nagineni nagineni requested a review from mourner July 26, 2018 14:20
@nagineni
Copy link
Contributor Author

@mourner could you please take a look?

@mourner mourner merged commit 0c6e2d5 into master Jul 26, 2018
@mourner mourner deleted the osx_build_fix branch July 26, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagineni @mourner