Support tvOS, watchOS #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added targets and a scheme for tvOS. Upgraded OHHTTPStubs to 5.0.0, which supports tvOS.
Added a target and scheme for watchOS support. watchOS doesn’t support test bundles, so no test target has been added. Use WKInterfaceDevice instead of UIScreen on watchOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve claimed tvOS support since d6f53fe and watchOS support since 1c224d3. But we’ve only been building frameworks for iOS (since #16) and OS X (since #21). It has been possible to use the CocoaPods pod on tvOS and watchOS, but watchOS support broke inadvertently in #19.
This PR fixes the watchOS compilation error and adds framework targets for tvOS and watchOS, along with a test target for tvOS – XCTest doesn’t support watchOS – to ensure that all four platforms are actually supported.
/cc @tmcw @friedbunny