Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Swift 5 #193

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Bump to Swift 5 #193

merged 1 commit into from
Jun 11, 2019

Conversation

frederoni
Copy link
Contributor

cc @1ec5

1ec5
1ec5 reviewed Jun 5, 2019
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy.

Remember to update the CocoaPods podspec and .swift-version:

MapboxGeocoder.swift/MapboxGeocoder.swift.podspec

Line 44 in ea443fd

s.swift_version = "4.2"

Maybe for the last time. 🤞

@frederoni frederoni merged commit ffb6c13 into master Jun 11, 2019
@frederoni frederoni deleted the swift-5 branch June 11, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederoni @1ec5