Fix non-exhaustive chip check #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160 Carthage Installation Fails when building for watchOS.
The cross-compiled fat file consists of
i386 armv7k arm64_32, however, theif arch(i386)compilation directive does not catch the i386 architecture when compiling for watchOS simulator despitesysctlbyname("hw.cputype")indicating x86CPU_TYPE_X86.This change works around this by checking for os when it should be checking for arch. I've also made the compilation directive exhaustive by adding an
unknownchip.Also, we should get Xcode 10 bots up and running.
@1ec5 @hyerra