Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed framework in example applications #149

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Embed framework in example applications #149

merged 1 commit into from
Jul 3, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jun 25, 2018

This change embeds MapboxGeocoder.framework into the Swift and Objective-C example applications.

/cc @captainbarbosa

@1ec5 1ec5 added the build label Jun 25, 2018
@1ec5 1ec5 self-assigned this Jun 25, 2018
@1ec5 1ec5 requested a review from captainbarbosa June 25, 2018 21:31
fabian-guerra
fabian-guerra approved these changes Jul 3, 2018
View reviewed changes
Copy link

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@1ec5 1ec5 merged commit a6a4153 into master Jul 3, 2018
@1ec5 1ec5 deleted the 1ec5-embed-framework branch July 3, 2018 22:55
@captainbarbosa captainbarbosa mentioned this pull request Jul 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian-guerra fabian-guerra fabian-guerra approved these changes

@captainbarbosa captainbarbosa Awaiting requested review from captainbarbosa

Assignees

@1ec5 1ec5

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @fabian-guerra