Upgrade to swift 4 #122
Merged
Upgrade to swift 4 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Nov 20, 2017
There was a problem hiding this comment.
Yay! Just upgraded the Bitrise apps to use Xcode 9.1 instead of 8.3.
Mind updating the README to mention that we’ll move the latest Swift 3.2 code to the swift3.2 branch?
|
@1ec5 updated. |
1ec5
reviewed
Nov 21, 2017
README.md
Outdated
| @@ -11,6 +11,8 @@ MapboxGeocoder.swift makes it easy to connect your iOS, macOS, tvOS, or watchOS | |||
|
|
|||
| MapboxGeocoder.swift pairs well with [MapboxDirections.swift](https://github.com/mapbox/MapboxDirections.swift), [MapboxStatic.swift](https://github.com/mapbox/MapboxStatic.swift), and the [Mapbox iOS SDK](https://www.mapbox.com/ios-sdk/) or [macOS SDK](https://github.com/mapbox/mapbox-gl-native/tree/master/platform/macos). | |||
|
|
|||
| MapboxGeocoder.swift requires Swift 4 as of v0.7.0. If you'd like to build for Swift 4, please target v0.6.3 or the branch [`swift3.2`](https://github.com/mapbox/MapboxGeocoder.swift/tree/swift3.2). | |||
There was a problem hiding this comment.
“If you'd like to build for Swift 3.2”, not “Swift 4”.
1ec5
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @friedbunny @1ec5