Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize rate limiting HTTP error #26

Closed
1ec5 opened this issue Feb 20, 2016 · 0 comments · Fixed by #41
Closed

Customize rate limiting HTTP error #26

1ec5 opened this issue Feb 20, 2016 · 0 comments · Fixed by #41
Labels
enhancement

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 20, 2016

TIMapboxGeocoder, which is essentially a fork of this project, handles HTTP error 429 by generating an NSError with specific rate limiting information gleaned from HTTP response headers. This project should do the same, since rate limiting is a basic scenario for the API.

/cc @friedbunny
1ec5 added a commit that referenced this issue May 22, 2016
@1ec5
Provide more details about API errors
ea922a7 
Include a failure reason from the response body in a failed request’s error. Include a hint when the error is due to rate-limiting. Split raw request and response logic into a separate method.

Fixes #26.
@1ec5 1ec5 mentioned this issue May 22, 2016
Merged
6 tasks
@1ec5 1ec5 closed this as completed in #41 May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revamp API to be more idiomatic in Swift mapbox/MapboxGeocoder.swift
1 participant
@1ec5