Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ViewPunch random for AR2 #245

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Mr0maks
Copy link

@Mr0maks Mr0maks commented Aug 25, 2023

Fixes wrong usage of SharedRandomInt (-12 < -8).

Does this PR close any issues?

Should fixes assert in vstdlib in debug build and correct random on x axis.

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link
Member

@Blixibon Blixibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit strange to open this PR now considering the MP branch port is not yet part of the main develop branch, and this also doesn't fix the same issue occurring in the singleplayer weapon_ar2 (even though it only uses the standard RandomInt and might not trigger an assertion failure).

Changes to the main develop branch will eventually be merged into the MP port anyway though, and I can apply this change to the singleplayer AR2 myself.

@Blixibon Blixibon merged commit 8e9020c into mapbase-source:develop Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants