Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption Fixes #230

Merged

Conversation

Petercov
Copy link

Fixes some issues with closed captions:

  • Fixed 'delay' parameter causing issues with caption fadeout order.
  • Fixed having many search paths preventing some caption files from loading.
  • Fixed caption files not loading from VPKs.

Does this PR close any issues?

  • (Optional) Insert issue number(s) and any related info here

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link
Member

@Blixibon Blixibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought it was intentional for the <delay> parameter to show its contents directly below the preceding line even if other captions have played between them, but it was really janky and it makes sense for this to actually be a bug with the fadeout order. I'm alright with that being fixed.

@Blixibon Blixibon merged commit 323f9fc into mapbase-source:develop Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants