Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advanced video options dialog box duplicate field name #1

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

arbabf
Copy link
Contributor

@arbabf arbabf commented Jan 29, 2023

This changes a duplicate 'Label8' field name (shared with the 'Shadow Quality' setting) to 'Label12', used by 'Color Correction', which keeps it consistent with its field definition's name.

The issue this fixes is the 'Shadow Quality' label being removed when modifying this resource file using the VGUI Build Mode editor (SHIFT+CTRL+ALT+B) and saving it without editing either label, as the duplicate field name overrides(?) the 'Shadow Quality' label's field name and causes it to get removed. This issue is also present in Half-Life 2.

This is unlikely to break any existing mods.

@Blixibon Blixibon merged commit c8bbffe into mapbase-source:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants