-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans to support GNOME 40? #151
Comments
Did you see #149? |
I didn't, either way this issue can be used for tracking progress. |
This is particularily intruiging, since this package has been selected for the Fedora package repository, and also provides builds for Fedora 34, which is delivered with GNOME 40. https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector |
Howdy, Fedora maintainer here. I'm happy to update this package as soon as there is a GNOME 40 compatible version tagged here in this repo. |
Please support Gnome 40! I love this extension and just updated. |
Gnome 41 is already out as well. |
I'm happily running this on Fedora 34 with GNOME 40 since a while from the
stock extensions repository.
https://extensions.gnome.org/extension/1162/emoji-selector/
What is missing for you here? Is there a specific reason why you cannot
install it from there, or why you have to use the packaged version?
@maoschanz Can you comment on the request by the Fedora package maintainer
above, when a tagged version of the GNOME 40 compatible source code could
become available? Many thanks in advance!
…On Mon, 8 Nov 2021 at 14:39, Nick Ribal ***@***.***> wrote:
Gnome 41 is already out as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMRV7DJE2SZ5VGWYKQIHVLUK7HHNANCNFSM42SMAAGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I'm not sure how you could install the extension on GNOME 40 from this page: on my side, it has the label Incompatible, and the shell version select does not list GNOME 40 (it stops at 3.38). |
Probably |
@carlwgeorge I look forward to the new pull request which adds proper 40/41+ support. Should work well in 42 too from there on. :) I use Fedora by the way, and I wonder what the difference is between this: https://extensions.gnome.org/extension/1162/emoji-selector/ and this: https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector Wouldn't it be better to install it from the extensions web to get updates that way? Hmm? |
@Bananaman Are you suggesting that I should send such a pull request? My expertise is in RPM packaging, not Javascript or CSS, so I'm not the right person for this task. Volunteering strangers for work you don't want to do yourself isn't really how open source works, so please don't do that in the future. As far as getting the extension from the extension website or from the Fedora RPM repositories, you get the same code in the end so it's your choice. Myself and many others prefer to do all installations/updates through the system package manager, which is why I maintain that RPM package. |
Setting that allows the extension to be installed successfully, although there could be complications of course 😄 |
It actually installs it and works, but it doesn't have any kind of settings though (just an error message in my case) |
same in Gnome 41.3 |
Is there no way of getting this to work on Gnome 41? If there is a working fork or anything, could someone please share 🙏🙏🙏 |
I haven't tried any forks, but if you add gnome 41 as a supported version of gnome it works. Just settings are broken. But if you have the time to find a working fork please share. |
Sorry, I misread your post and thought you were working on a pull request. :P |
Just to share, I just installed https://github.com/tom-james-watson/Emote - the app size is insane but it works, I was able to change the shortcut easily ^^" and it pastes instantly the selected emoji. |
@julianferres one of the ways of accessing/modifying settings for now can be via gsettings.
|
Does it launch really slowly for you? |
yep :-( switched back to emoji-selector thanks to Karuna's info on how to change the settings without the UI |
Yes, when I launched it the first time, i had enough time to recheck if I added the shortcut correctly. Before being presented with three instances (because I'm really impatient). Overall it's better than nothing, but the startup speed is ridiculous. |
#149 has been merged so this should be closed I think? |
Has it been released? Can someone confirm it works? I'll close the issue then |
the prefs window works but the new version of the extension isn't released yet so the issue should stay opened for now |
Seems like it's been 19 days since the new version had released on github but it's not on EGO yet. It's a long time for the review process. Is the new version still waiting for the review? Is there a problem on that side? |
I have installed master branch ( |
@maoschanz I assume it's rejected on the review. If you can give us a clue why it's been rejected (they usually tell you on the review page, if not you can always ask) I can try to help you for making it meet the requirements of Review Guidelines |
It's rejected for small things here and there but there is a bigger bug: the recent emojis' list isn't restored when reloading gnome shell, I noticed it only after the rejection Sadly I've broken my computer so I can only answer mentions or merge PRs from my phone, I can't even diagnose the issue... (And I can't even develop Drawing!! 😭 my 2+ years weekly contribution streak is ruined 😓) I've another vacation for the last two weeks of August I'll use that time to install my dear debian Sid on a new machine and finish the gnome 40+ support of this extension, the quicklists one, and the notes one edit: to answer your question, the exact content of the review is:
CAT_LABELS = null;
SIGNAUX = [];
recents = [];
|
(again, caused by dead code coming back from a merge request)
Wow! It works now directly from the gnome extensions store!! 🎉 Great kudos to @maoschanz ❤️ |
Thanks for bringing this back :-) |
@maoschanz yesssss thank you! Love this package! |
Are there plans to support GNOME 40?
The text was updated successfully, but these errors were encountered: