Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support GNOME 40? #151

Closed
shilangyu opened this issue Apr 8, 2021 · 33 comments
Closed

Plans to support GNOME 40? #151

shilangyu opened this issue Apr 8, 2021 · 33 comments

Comments

@shilangyu
Copy link

Are there plans to support GNOME 40?

@AlexWayfer
Copy link

Did you see #149?

@shilangyu
Copy link
Author

I didn't, either way this issue can be used for tracking progress.

@almereyda
Copy link

This is particularily intruiging, since this package has been selected for the Fedora package repository, and also provides builds for Fedora 34, which is delivered with GNOME 40.

https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector

@carlwgeorge
Copy link
Contributor

Howdy, Fedora maintainer here. I'm happy to update this package as soon as there is a GNOME 40 compatible version tagged here in this repo.

@vjxyz
Copy link

vjxyz commented Oct 30, 2021

Please support Gnome 40! I love this extension and just updated.

@elektronik2k5
Copy link

Gnome 41 is already out as well.

@almereyda
Copy link

almereyda commented Nov 10, 2021 via email

@Deuchnord
Copy link

I'm not sure how you could install the extension on GNOME 40 from this page: on my side, it has the label Incompatible, and the shell version select does not list GNOME 40 (it stops at 3.38).
Are you sure you are running GNOME 40?

@carlwgeorge
Copy link
Contributor

Probably /org/gnome/shell/disable-extension-version-validation set to true.

@Arcitec
Copy link

Arcitec commented Dec 3, 2021

@carlwgeorge I look forward to the new pull request which adds proper 40/41+ support. Should work well in 42 too from there on. :)

I use Fedora by the way, and I wonder what the difference is between this:

https://extensions.gnome.org/extension/1162/emoji-selector/

and this:

https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector

Wouldn't it be better to install it from the extensions web to get updates that way? Hmm?

@carlwgeorge
Copy link
Contributor

@Bananaman Are you suggesting that I should send such a pull request? My expertise is in RPM packaging, not Javascript or CSS, so I'm not the right person for this task. Volunteering strangers for work you don't want to do yourself isn't really how open source works, so please don't do that in the future.

As far as getting the extension from the extension website or from the Fedora RPM repositories, you get the same code in the end so it's your choice. Myself and many others prefer to do all installations/updates through the system package manager, which is why I maintain that RPM package.

@carestad
Copy link

carestad commented Jan 5, 2022

Probably /org/gnome/shell/disable-extension-version-validation set to true.

Setting that allows the extension to be installed successfully, although there could be complications of course 😄

@julianferres
Copy link

Probably /org/gnome/shell/disable-extension-version-validation set to true.

Setting that allows the extension to be installed successfully, although there could be complications of course smile

It actually installs it and works, but it doesn't have any kind of settings though (just an error message in my case)

Screenshot from 2022-01-15 04-46-51

@MSandro
Copy link

MSandro commented Jan 27, 2022

It actually installs it and works, but it doesn't have any kind of settings though (just an error message in my case)

same in Gnome 41.3

@Syzygianinfern0
Copy link

Is there no way of getting this to work on Gnome 41? If there is a working fork or anything, could someone please share 🙏🙏🙏

@joelimgu
Copy link

I haven't tried any forks, but if you add gnome 41 as a supported version of gnome it works. Just settings are broken. But if you have the time to find a working fork please share.

@Arcitec
Copy link

Arcitec commented Jan 30, 2022

Are you suggesting that I should send such a pull request? My expertise is in RPM packaging, not Javascript or CSS, so I'm not the right person for this task. Volunteering strangers for work you don't want to do yourself isn't really how open source works, so please don't do that in the future.

Sorry, I misread your post and thought you were working on a pull request. :P

@cmalard
Copy link

cmalard commented Apr 29, 2022

Just to share, I just installed https://github.com/tom-james-watson/Emote - the app size is insane but it works, I was able to change the shortcut easily ^^" and it pastes instantly the selected emoji.
image

@KarunaGovind
Copy link

KarunaGovind commented May 1, 2022

@julianferres one of the ways of accessing/modifying settings for now can be via gsettings.

# Show all settings
gsettings --schemadir ~/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/schemas list-keys org.gnome.shell.extensions.emoji-selector

# Modify a specific settings
gsettings --schemadir ~/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/schemas get org.gnome.shell.extensions.emoji-selector always-show
true

@Syzygianinfern0
Copy link

Just to share, I just installed https://github.com/tom-james-watson/Emote - the app size is insane but it works, I was able to change the shortcut easily ^^" and it pastes instantly the selected emoji. image

Does it launch really slowly for you?

@cmalard
Copy link

cmalard commented May 10, 2022

yep :-( switched back to emoji-selector thanks to Karuna's info on how to change the settings without the UI

@Syzygianinfern0
Copy link

yep :-( switched back to emoji-selector thanks to Karuna's info on how to change the settings without the UI

Check out rofimoji. It is really snappy and quite customizable.

@ccoenen
Copy link

ccoenen commented May 10, 2022

Does it launch really slowly for you?

Yes, when I launched it the first time, i had enough time to recheck if I added the shortcut correctly. Before being presented with three instances (because I'm really impatient). Overall it's better than nothing, but the startup speed is ridiculous.

@yavko
Copy link

yavko commented May 23, 2022

#149 has been merged so this should be closed I think?

@shilangyu
Copy link
Author

Has it been released? Can someone confirm it works? I'll close the issue then

@maoschanz
Copy link
Owner

the prefs window works but the new version of the extension isn't released yet so the issue should stay opened for now

@ulville
Copy link

ulville commented Jul 9, 2022

Seems like it's been 19 days since the new version had released on github but it's not on EGO yet. It's a long time for the review process. Is the new version still waiting for the review? Is there a problem on that side?

@stephane-klein
Copy link

I have installed master branch (380b572911b4ff2d8de026cbcefd89f2137143c9) on Fedora 36 with Gnome 42.3, emoji-selector-for-gnome works with success with Wayland 👍

@ulville
Copy link

ulville commented Aug 1, 2022

@maoschanz I assume it's rejected on the review. If you can give us a clue why it's been rejected (they usually tell you on the review page, if not you can always ask) I can try to help you for making it meet the requirements of Review Guidelines

@maoschanz
Copy link
Owner

maoschanz commented Aug 1, 2022

It's rejected for small things here and there but there is a bigger bug: the recent emojis' list isn't restored when reloading gnome shell, I noticed it only after the rejection

Sadly I've broken my computer so I can only answer mentions or merge PRs from my phone, I can't even diagnose the issue... (And I can't even develop Drawing!! 😭 my 2+ years weekly contribution streak is ruined 😓)

I've another vacation for the last two weeks of August I'll use that time to install my dear debian Sid on a new machine and finish the gnome 40+ support of this extension, the quicklists one, and the notes one

edit: to answer your question, the exact content of the review is:

  1. You should remove the timeout in disable (extension.js line 214):
    https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
  1. Also do this in disable:
CAT_LABELS = null;
SIGNAUX = [];
recents = [];
  1. Remove convenience.js since you are not using it.

maoschanz added a commit that referenced this issue Aug 5, 2022
(again, caused by dead code coming back from a merge request)
maoschanz added a commit that referenced this issue Aug 6, 2022
@Syzygianinfern0
Copy link

Wow! It works now directly from the gnome extensions store!! 🎉

Great kudos to @maoschanz ❤️

@ccoenen
Copy link

ccoenen commented Aug 7, 2022

Thanks for bringing this back :-)

@t-lock
Copy link

t-lock commented Aug 9, 2022

@maoschanz yesssss thank you! Love this package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests