🐛 fix DefectDojo#7690, microfocus webinspect NoneType Object

manuel-sommer · Jan 14, 2024 · 6845f8c · 6845f8c
1 parent 42548de
commit 6845f8c
Show file tree

Hide file tree

Showing 3 changed files with 38,879 additions and 11 deletions.
diff --git a/dojo/tools/microfocus_webinspect/parser.py b/dojo/tools/microfocus_webinspect/parser.py
@@ -55,17 +55,13 @@ def get_findings(self, file, test):
                 cwe = 0
                 description = ""
                 classifications = issue.find("Classifications")
-                for content in classifications.findall("Classification"):
-                    # detect CWE number
-                    # TODO support more than one CWE number
-                    if (
-                        "kind" in content.attrib
-                        and "CWE" == content.attrib["kind"]
-                    ):
-                        cwe = MicrofocusWebinspectParser.get_cwe(
-                            content.attrib["identifier"]
-                        )
-                        description += "\n\n" + content.text + "\n"
+                if classifications is not None:
+                    for content in classifications.findall('Classification'):
+                        # detect CWE number
+                        # TODO support more than one CWE number
+                        if "kind" in content.attrib and "CWE" == content.attrib["kind"]:
+                            cwe = MicrofocusWebinspectParser.get_cwe(content.attrib['identifier'])
+                            description += "\n\n" + content.text + "\n"
 
                 finding = Finding(
                     title=issue.findtext("Name"),
@@ -114,6 +110,8 @@ def convert_severity(val):
             return "Medium"
         elif val == "3":
             return "High"
+        elif val == "4":
+            return "Critical"
         else:
             return "Info"