Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clip paths to floating arrow #7148

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

th3fallen
Copy link
Contributor

Add clip paths to floating arrow to prevent larger arrow sizes from being visible when hovering a child component (like in menus)

Current Arrow with red background color for clarity:
Menu - Controlled ⋅ Storybook 2024-11-20 at 1 34 46 PM

With clip paths:
Menu - Controlled ⋅ Storybook 2024-11-20 at 1 38 26 PM

With clip paths without background for clarity:
Menu - Controlled ⋅ Storybook 2024-11-20 at 1 39 01 PM

Add clip paths to floating arrow to prevent larger arrow sizes from being visible when hovering a child component (like in menus)
@rtivital
Copy link
Member

What happens if I want my popover to:

  • have border
  • have custom background (for example, silver)
  • ave arrow that matches the color with popover

@th3fallen
Copy link
Contributor Author

What happens if I want my popover to:

  • have border
  • have custom background (for example, silver)
  • ave arrow that matches the color with popover

All of those cases still work as before.

@rtivital rtivital merged commit 1e23e6f into mantinedev:master Nov 23, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants