Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with CompositeChart #7010

Closed
1 of 2 tasks
plantaest opened this issue Oct 22, 2024 · 6 comments · Fixed by #7020
Closed
1 of 2 tasks

Issue with CompositeChart #7010

plantaest opened this issue Oct 22, 2024 · 6 comments · Fixed by #7020

Comments

@plantaest
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.13.3

What package has an issue?

@mantine/charts

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Chrome

Describe the bug

I use CompositeChart with the following code:

<CompositeChart
  h={185}
  data={chartData}
  dataKey="date"
  maxBarWidth={30}
  withRightYAxis
  series={[
    { name: 'views', label: 'Số lượt xem', color: 'yellow.8', type: 'area' },
    {
      name: 'edits',
      label: 'Số sửa đổi',
      color: 'rgba(18, 120, 255, 0.2)',
      yAxisId: 'right',
      type: 'bar',
    },
  ]}
  curveType="monotone"
  gridAxis="none"
/>

But the Chrome console shows this error:
Screenshot 2024-10-22 at 16 53 47

I think we should add key prop to this line:

Regards,
Plantaest.

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@mariakax3
Copy link
Contributor

Hello, I'd love the opportunity to contribute to this issue.

@rtivital
Copy link
Member

You are welcome to submit a PR with a fix

@Kenzo-Wada
Copy link
Contributor

@plantaest BTW, The UI design of your product is aaaaawesome!!! nice job!

@plantaest
Copy link
Author

@Kenzo-Wada Yeah, thank you so much! This is an open-source application that I'm developing. You can check it out here: https://github.com/plantaest/zinnia. To run it, you should have an account on the Meta-Wiki platform: https://meta.wikimedia.org/, as it's used to handle tasks there.

This project wouldn't have such a good UI without the talented author of Mantine, @rtivital. Thank you so much!

@mariakax3 Thank you for your interest, I hope to see a PR for this issue soon.

Screenshot 2024-10-23 at 21 38 57 Screenshot 2024-10-23 at 21 38 16

@mariakax3
Copy link
Contributor

@rtivital Could I request permission to push changes to the repository? Currently I'm encountering 403 response

@plantaest
Copy link
Author

@mariakax3 I suggest you create a fork. You can read more about it here: https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants