This repository has been archived by the owner on May 3, 2024. It is now read-only.
Both ip versions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! I will look through your PR shortly. |
|
I have read through and commented on your proposed changes. Thanks again for taking your time to contribute to RxBonjour! |
|
Thanks for detailed notes. Sorry for that mess. Here is commit according to your comments. |
|
Looks good! Please rename the InetAddress accessor methods according to my comments and we're good to go! edit: Actually, since this is such a minor change, I'll do it myself. The syntax will be |
|
Released in 0.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of RxBonjour returns one random host IP of BonjourService if there were actually both IPv4 and IPv6 versions.
I need specific host IP.