add support for stack policies (create and override) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
I'd like someone more familiar with using cf_deployer to check this over too, though, as I've never used it for anything.
|
the travis failure looks like travis itself or a ruby gem thing, not the changee. I don't see the little icon to rebuild. I thought travis had that? |
| @@ -82,7 +82,15 @@ Used by the gem for blue/green deployments and naming conventions | |||
| * keep-previous-stack (True/False: for Cname-Swap and Auto Scaling Group Swap, previous stack will be kept after new stack is created by default. Set it to false to delete the previous stack) | |||
| * raise-error-for-unused-inputs (True/False: it is false by default. If it is set to true, errors will be thrown if there are any inputs which are not used as parameters of CloudFormation json templates. If it is set to false or the setting does not exist, warnings will be printed in the console if there are un-used inputs.) | |||
| * auto-scaling-group-name-output | |||
| * **For Components Using the Cname-Swap Deployment Strategy** | |||
| * create-stack-policy-filename: the name of the json file (w/o the json | |||
There was a problem hiding this comment.
thinking these setting shouldn't have "filename" in the name. to be consistent with how cf_deploy works, i.e. the file'ness and location of these should be inferred relative to the config dir. change coming up shortly to remove "-filename" from the setting names...
added 3 commits
April 12, 2016 08:26
…ployer - better explanation in docs of usage of the override policy
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kmanning @jantman