Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroying route via silentRefresh when using hash strategy (Issue 277) #672

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Fix destroying route via silentRefresh when using hash strategy (Issue 277) #672

merged 2 commits into from
Mar 2, 2020

Conversation

tpeter1985
Copy link
Contributor

Fix for #277

@tpeter1985
Copy link
Contributor Author

I think this should solve #277
It is the same condition as 26 lines above, hope this works and does not break anything.
It worked in my environment and fixed the problem.

@jeroenheijmans
Copy link
Collaborator

Change makes sense to me. Would you agree that this third location would then also need this fix?

@tpeter1985
Fix issue 277 II
2d5a583 
Unify conditions used to clear hash
@tpeter1985
Copy link
Contributor Author

Change makes sense to me. Would you agree that this third location would then also need this fix?

Nice additional finding, thank you, I fixed the third location as well.

@tpeter1985 tpeter1985 changed the title Fix Issue 277 Fix destroying route via silentRefresh when using hash strategy (Issue 277) Nov 18, 2019
@manfredsteyer manfredsteyer merged commit a21079b into manfredsteyer:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpeter1985 @jeroenheijmans @manfredsteyer