Support hash location strategy with code flow #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingters
changed the title
gingters
force-pushed
the
bugfix/codeFlow-hashLocationStrategy
branch
from
0ac4ae8 to
e448314
Compare
|
I found this fix very useful. I am dealing with the same problem with an Azure IdentityServer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #594
Renamed and moved
parseQueryStringonOAuthServicetogetCodePartsFromUrland changed it so that ifwindow.location.searchis empty, it will try to get the parameters from the hash part (re-usinggetHashFragmentParams()on the urlHelper, which is also already used intryLoginImplicitFlow).Also added a checkbox to the sample page to toggle the sample app between path and hash location strategy in order to test this.
Should work also with implicit flow, but the redirect uri with the hash route is not yet recognized by the IdentityServer3 instance on
steyer-identity-server.azurewebsites.net, so that needs to be configured to also support the redirect uri with the hash for the sample test case for implicit flow.