Always set expiration timers for valid token types #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only setting a token expiration timer for the shortest
living token type, set timers for both token types as long as they are
valid.
This solves the remaining issue mentioned by @davdev82 in #432 and #462: If the id token has a shorter lifespan than the access token andyou configure setupAutomaticSilentRefresh to only listen to access token expiration, the token will never be refreshed. Because the filtering of the token expiration of token types now happens in setupAutomaticSilentRefresh(), setupExpirationTimers() should set timers for both token types.
With this commit, the
events
Observable now emits when either the id token or the access token expires (instead of only the one with the shortest lifetime), which is also more complete behavior.