Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.x Shift #3

Closed
wants to merge 9 commits into from
Closed

Laravel 6.x Shift #3

wants to merge 9 commits into from

Conversation

mandudeman
Copy link
Owner

This pull request includes the changes for upgrading to Laravel 6.x. Feel free to commit any additional changes to the shift-60235 branch.

Before merging, you need to:

  • Checkout the shift-60235 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, add --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

Shift automatically applies the Laravel coding style - which uses the PSR-2 coding style as a base with some minor additions.

You may customize the code style applied by adding a [PHP CS Fixer][1] or [PHP CodeSniffer][2] ruleset to your project root. Feel free to use [Shift's Laravel ruleset][3] to help you get started.

For more information on customizing the code style applied by Shift, [watch this short video][4].

[1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
[2]: https://github.com/squizlabs/PHP_CodeSniffer
[3]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
[4]: https://laravelshift.com/videos/shift-code-style
PHP 5.5.9+ adds the new static `class` property which provides the fully qualified class name. This is preferred over using strings for class names since the `class` property references are checked by PHP.
Laravel recommends using the `Str` and `Arr` class methods directly instead of the respective helper functions. These helper functions are deprecated in Laravel 5.8 and removed in Laravel 6.
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.
@mandudeman
Copy link
Owner Author

❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 6 versions and merge any changes:

  • app/Http/Controllers/Auth/ResetPasswordController.php
  • app/Http/Kernel.php

@mandudeman
Copy link
Owner Author

⚠️ Laravel 6.x consolidated references to /home as a constant within the RouteServiceProvider. This makes it easier to maintain and change in a single place.

Shift automated this change, but could not upgrade the following files since they differed from the default Laravel version. You should compare these files against the default Laravel 6 versions and merge this change:

  • app/Http/Controllers/Auth/LoginController.php
  • app/Http/Controllers/Auth/RegisterController.php
  • app/Http/Controllers/Auth/VerificationController.php

@mandudeman
Copy link
Owner Author

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert c3118cbe and make the config file changes manually.

@mandudeman
Copy link
Owner Author

ℹ️ Laravel 6 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.

@mandudeman
Copy link
Owner Author

ℹ️ Shift updated your dependencies for Laravel 6. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 6.

Watch dealing with dependencies for tips on handling any additional package incompatibilities.

@mandudeman
Copy link
Owner Author

ℹ️ Laravel 6 now requires Carbon 2. While Shift reviewed your application for common breaking changes, you may want to review the Carbon 2 migration notes for additional changes.

@mandudeman
Copy link
Owner Author

⚠️ Previous versions of Laravel would bind parameters passed to the URL helper methods as placeholder values even if the names mismatched. In Laravel 6, named parameters not matching placeholders are attached to the query string instead.

Shift detected the following route() and action() calls passing named parameters you should review to ensure they match the route placeholder name.

  • resources/views/admin/bank-cash/edit.blade.php
  • resources/views/admin/bank-cash/index.blade.php
  • resources/views/admin/bank-cash/trashed.blade.php
  • resources/views/admin/branch/edit.blade.php
  • resources/views/admin/branch/index.blade.php
  • resources/views/admin/branch/trashed.blade.php
  • resources/views/admin/cnt-voucher/edit.blade.php
  • resources/views/admin/cnt-voucher/index.blade.php
  • resources/views/admin/cnt-voucher/trashed.blade.php
  • resources/views/admin/cr-voucher/edit.blade.php
  • resources/views/admin/cr-voucher/index.blade.php
  • resources/views/admin/cr-voucher/trashed.blade.php
  • resources/views/admin/dr-voucher/edit.blade.php
  • resources/views/admin/dr-voucher/index.blade.php
  • resources/views/admin/dr-voucher/trashed.blade.php
  • resources/views/admin/income-expense-group/edit.blade.php
  • resources/views/admin/income-expense-group/index.blade.php
  • resources/views/admin/income-expense-group/trashed.blade.php
  • resources/views/admin/income-expense-head/edit.blade.php
  • resources/views/admin/income-expense-head/index.blade.php
  • resources/views/admin/income-expense-head/trashed.blade.php
  • resources/views/admin/income-expense-type/edit.blade.php
  • resources/views/admin/income-expense-type/index.blade.php
  • resources/views/admin/income-expense-type/trashed.blade.php
  • resources/views/admin/initial-bank-cash-balance/edit.blade.php
  • resources/views/admin/initial-bank-cash-balance/index.blade.php
  • resources/views/admin/initial-bank-cash-balance/trashed.blade.php
  • resources/views/admin/initial-income-expense-head-balance/edit.blade.php
  • resources/views/admin/initial-income-expense-head-balance/index.blade.php
  • resources/views/admin/initial-income-expense-head-balance/trashed.blade.php
  • resources/views/admin/jnl-voucher/edit.blade.php
  • resources/views/admin/jnl-voucher/index.blade.php
  • resources/views/admin/jnl-voucher/trashed.blade.php
  • resources/views/admin/profile/index.blade.php
  • resources/views/admin/role-manage/edit.blade.php
  • resources/views/admin/role-manage/index.blade.php
  • resources/views/admin/role-manage/trashed.blade.php
  • resources/views/admin/user/edit.blade.php
  • resources/views/admin/user/index.blade.php
  • resources/views/admin/user/trashed.blade.php

@mandudeman
Copy link
Owner Author

ℹ️ Laravel 6 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@mandudeman
Copy link
Owner Author

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@mandudeman
Copy link
Owner Author

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@mandudeman
Copy link
Owner Author

⚠️ Laravel 6.x has reached end of life. It no longer receives bug fixes. Shift recommends continuing to upgrade to the latest version (Laravel 9.x).

For tips on running multiple Shifts effectively, watch upgrading old Laravel applications.

@mandudeman mandudeman closed this Apr 16, 2022
@mandudeman mandudeman deleted the shift-60235 branch April 16, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants